This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2 15/16] arm: Define __memchr

From: Richard Henderson <rth at twiddle dot net>
To: Joseph Myers <joseph at codesourcery dot com>
Cc: libc-alpha at sourceware dot org
Date: Fri, 23 Dec 2016 10:54:59 -0800
Subject: Re: [PATCH v2 15/16] arm: Define __memchr
Authentication-results: sourceware.org; auth=none
References: <20161221230605.28638-1-rth@twiddle.net> <20161221230605.28638-16-rth@twiddle.net> <alpine.DEB.2.20.1612220023060.12584@digraph.polyomino.org.uk>

On 12/21/2016 04:25 PM, Joseph Myers wrote:
> On Wed, 21 Dec 2016, Richard Henderson wrote:
> 
>> All other memchr implementations define it.
> 
> But since memchr is a C90 function (so there are no external-linkage 
> namespace issues), and not used in any macros defined in installed headers 
> (so no block-scope namespace issues), is there any actual use for 
> __memchr, or should all the implementations just define memchr and not 
> __memchr?
> 

It's an excellent question.  As best I can tell, __memchr is no longer used (or
was never used -- it's hard to tell) at all.

Probably it should be purged from all of the implementations.


r~

References:
- [PATCH v2 00/16] Improve generic string routines
  - From: Richard Henderson
- [PATCH v2 15/16] arm: Define __memchr
  - From: Richard Henderson
- Re: [PATCH v2 15/16] arm: Define __memchr
  - From: Joseph Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]