This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 09/15] De-PLTize __stack_chk_fail internal calls within libc.so.


On 21 Dec 2016, Florian Weimer uttered the following:

> On 12/19/2016 12:15 PM, Nix wrote:
>> From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>>
>> We use the same assembler-macro trick we use to de-PLTize
>> compiler-generated libcalls to memcpy and memset to redirect
>> __stack_chk_fail to __stack_chk_fail_local.
>>
>> v5: New.
>> v6: Only do it within the shared library: with __stack_chk_fail_local
>>     in libc_pic.a now we don't need to worry about calls from inside
>>     other routines in libc_nonshared.a any more.
>> v8: Merge #ifdef blocks.
>> v10: Use STACK_PROTECTOR_LEVEL to avoid renaming in files where
>>      stack-protection is suppressed.
>>
>> 	* sysdeps/generic/symbol-hacks.h [STACK_PROTECTOR_LEVEL &&
>> 	STACK_PROTECTOR_LEVEL > 0] (__stack_chk_fail): Add internal alias.
>
> I'm going to fold this into the previous commit.

I was tempted but thought that it might be a bit presumptuous for
a newbie like me to preempt Adhemerval :)

-- 
NULL && (void)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]