This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v3] Add configure check for python program
- From: Steve Ellcey <sellcey at caviumnetworks dot com>
- To: Siddhesh Poyarekar <siddhesh at sourceware dot org>, <libc-alpha at sourceware dot org>
- Date: Thu, 22 Dec 2016 09:24:13 -0800
- Subject: Re: [PATCH v3] Add configure check for python program
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Steve dot Ellcey at cavium dot com;
- References: <1482374274-10269-1-git-send-email-siddhesh@sourceware.org>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Thu, 2016-12-22 at 08:07 +0530, Siddhesh Poyarekar wrote:
> Add a configure check that looks for python3 and python in that order
> since we had agreed in the past to prefer python3 over python in all
> our code. The patch also adjusts invocations through the various
> Makefiles to use the set variable.
>
> Changes:
>
> - Added tests-printers to tests-unsupported instead of removing
> them.
>
> * configure.ac: Check for python3 or python.
> * configure: Regenerated.
> * config.make.in (PYTHON): New variable.
> * benchtests/Makefile: Don't define PYTHON.
> (bench): Define target only if PYTHON was defined.
> * Rules: Don't define PYTHON.
> Define pretty printer targets only if PYTHON was defined.
> (tests-printers): Add to tests-unsupported if PYTHON is not
> found.
> (python-flags, python-invoke): Remove.
> (tests-printers-out): Use PYTHON instead of python-invoke.
Yes, I like this version better. It worked fine on my machine.
Steve Ellcey
sellcey@caviumnetworks.com