This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH COMMITTED] Do not require memset elimination in explicit_bzero test
- From: Florian Weimer <fweimer at redhat dot com>
- To: libc-alpha at sourceware dot org, Stefan Liebler <stli at linux dot vnet dot ibm dot com>
- Date: Wed, 21 Dec 2016 19:04:41 +0100
- Subject: Re: [PATCH COMMITTED] Do not require memset elimination in explicit_bzero test
- Authentication-results: sourceware.org; auth=none
- References: <20161220100941.B4FA5401BD5F6@oldenburg.str.redhat.com>
On 12/20/2016 11:09 AM, Florian Weimer wrote:
Some targets fail to apply dead store elimination to the
memset call in setup_ordinary_clear. Before this commit,
this causes the test case to fail. Instead, the test case
now logs lack of memset elimination as an informational
message.
2016-12-20 Florian Weimer <fweimer@redhat.com>
Do not require memset elimination in explicit_bzero test.
* string/tst-xbzero-opt.c (prepare_test_buffer): Force inlining.
(enum test_expectation): Add NO_EXPECTATIONS.
(subtests): NO_EXPECTATIONS for ordinary clear.
(check_test_buffer): Handle NO_EXPECTATIONS.
* string/Makefile (CFLAGS-tst-xbzero-opt.c): Compile with -O3.
Stefan, this test still fails for me on s390x:
PASS: no clear/prepare: expected 32 got 32
PASS: no clear/test: expected some got 32
PASS: ordinary clear/prepare: expected 32 got 32
INFO: ordinary clear/test: found 0 patterns (memset not eliminated)
PASS: explicit clear/prepare: expected 32 got 32
FAIL: explicit clear/test: expected 0 got 1
Do you have an idea what's going on there?
Thanks,
Florian