This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 1/5] manual: Refactor header and standards annotations.
On Mon, 19 Dec 2016, Rical Jasan wrote:
> And now would probably be a better time to update the syntax comment in
> summary.awk, which may not show up for a while otherwise (in [v2 4/5];
> presently unreviewed). I was also thinking of adjusting it a bit:
>
> # This script recognizes sequences that look like:
> -# @comment HEADER.h
> +# @comment HEADER.h[ ...]
> # @comment STANDARD
> # @def... ITEM | @item ITEM | @vindex ITEM
> +# where multiple headers must be space-separated and STANDARD is
> +# essentially free-form.
>
> Should I submit a v3 for this, stick to v2, or go ahead and commit with
> the suggested updates?
Where a patch or part of a patch has been approved and that change is
still the form you want to get in, you should commit it.
If something has not been approved, or it's been approved but you want to
make further changes beyond what counts as obvious (e.g. routine fixes for
merge conflicts, or fixing a typo in your changes, are generally obvious),
a new patch revision should be submitted. Feel free to split the
summary.awk updates out into a separate patch in the next revision if that
seems useful for review.
--
Joseph S. Myers
joseph@codesourcery.com