This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 06 Dec 2016 08:48, Zack Weinberg wrote: > --- /dev/null > +++ b/bits/types/siginfo_t.h > @@ -0,0 +1,21 @@ > +#ifndef __siginfo_t_defined > +#define __siginfo_t_defined 1 imo, all headers like this should have a comment block at the top. i don't mind ones that are a simple #include redirect, but when there's actual code, i think we should err on the side of being overly verbose. > --- a/inet/rcmd.c > +++ b/inet/rcmd.c > @@ -112,7 +113,8 @@ > struct sockaddr_in6 sin6; > } from; > struct pollfd pfd[2]; > - int32_t oldmask; > + sigset_t mask, omask; should double check your indentation > + __sigemptyset(&mask); > + __sigaddset(&mask, SIGURG); > + __sigprocmask (SIG_BLOCK, &mask, &omask); GNU style puts a space before the ( -mike
Attachment:
signature.asc
Description: Digital signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |