This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][x86_64] Disable TSX on some Haswell processors
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>, Andi Kleen <andi dot kleen at intel dot com>
- Date: Fri, 16 Dec 2016 16:00:39 -0500
- Subject: Re: [PATCH][x86_64] Disable TSX on some Haswell processors
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3vgYW8oJk257MvNReErGoUELUVmCVVZJYBWFADC2mgO8A@mail.gmail.com> <df75aac6-55a5-7767-bab4-700d15883da9@redhat.com> <CAMXFM3snRTk_NCz=4-xJS0gScWKBRNxANwmrpqu+EwPY+apoGw@mail.gmail.com>
On 12/15/2016 10:37 AM, Andrew Senkevich wrote:
> 2016-12-14 22:13 GMT+03:00 Carlos O'Donell <carlos@redhat.com>:
> . . . . .
>>
>> Case 0x3f needs a comment explaining why we break out early.
>>
>>> + case 0x3f:
>>> + if (stepping >= 4)
>>> + break;
>
> Here is version with added comment and ChangeLog. Ok for commit?
So long as your tabs are fixed in the final commit, then yes,
this looks good to me.
Thank you very much for the background research and verification
to get this blacklist in place which will allow us to move forward
more aggressively in allowing applications to use RTM with glibc.
--
Cheers,
Carlos.