This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [GLIBC][PATCH] Remove strdup inlines

From: Zack Weinberg <zackw at panix dot com>
To: Wilco Dijkstra <Wilco dot Dijkstra at arm dot com>
Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
Date: Mon, 12 Dec 2016 07:26:25 -0500
Subject: Re: [GLIBC][PATCH] Remove strdup inlines
Authentication-results: sourceware.org; auth=none
References: <AM5PR0802MB26104922C496F25DABAFC47283980@AM5PR0802MB2610.eurprd08.prod.outlook.com>

On Mon, Dec 12, 2016 at 7:00 AM, Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:
> Remove the str(n)dup inlines from string/bits/string2.h.  Although inlining
> calls with constant strings shows a small (~10%) performance gain, strdup is
> typically used in error reporting code, so not performance critical.

Looks good to me.

This is the sole user of __need_malloc_and_calloc, so please also remove the
logic implementing that from {include,stdlib}/stdlib.h.

zw

Follow-Ups:
- Re: [GLIBC][PATCH v2] Remove strdup inlines
  - From: Wilco Dijkstra

References:
- [GLIBC][PATCH] Remove strdup inlines
  - From: Wilco Dijkstra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]