This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Convert signal.h from __need macros to bits/types/ headers.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 6 Dec 2016 16:34:25 +0000
- Subject: Re: [PATCH] Convert signal.h from __need macros to bits/types/ headers.
- Authentication-results: sourceware.org; auth=none
- References: <20161206134825.25301-1-zackw@panix.com>
On Tue, 6 Dec 2016, Zack Weinberg wrote:
> - if (dest == NULL || left == NULL || right == NULL)
> + if (!dest || !left || !right)
glibc style avoids implicit boolean conversions, so prefers == NULL here
and anywhere else in the patch making such a change.
https://sourceware.org/glibc/wiki/Style_and_Conventions#Boolean_Coercions
--
Joseph S. Myers
joseph@codesourcery.com