This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

How should files be moved in the glibc repository


I have a question about moving files in GIT and how that should be
done in the glibc repository.  As part of the aarch64 ILP32 patches
that I am getting ready to submit I am creating some subdirectories
(ilp32 and lp64) and moving some existing files, mostly abilist files,
from the parent directory down to the lp64 directory.  Should I do a
'git mv' or a 'git rm / git add' to move these files?  Or does it matter?

Right now, in the patch I am creating, I do 'git rm/git add' and I noticed
that if I applied the patches to a clean tree, the files I removed do not
actually get removed from my source tree.

The files are not in the tree where I create the patch and if I do a 
git status they show up as deleted.  But when I create the patch there
does not seem to be anything in it that would record that these files
are deleted and if I apply the patch to a new git tree with the patch
command, the deleted files still appear in that tree.  The new files are
created as expected, but the old ones are not deleted.  This causes build
problems unless the deleted files are removed by hand.  Am I doing something
wrong when creating the patch?  Should I use 'git mv' instead?

Steve Ellcey
sellcey@caviumnetworks.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]