This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] [ia64] Make all of sysdeps/ia64/fpu/libm-symbols.h only visible to libc||libm
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Zack Weinberg <zackw at panix dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, <vapier at gentoo dot org>
- Date: Mon, 21 Nov 2016 17:50:33 +0000
- Subject: Re: [PATCH] [ia64] Make all of sysdeps/ia64/fpu/libm-symbols.h only visible to libc||libm
- Authentication-results: sourceware.org; auth=none
- References: <3d50ecc9-2c08-6bf9-53c8-1e66bbe5aab1@panix.com>
On Mon, 21 Nov 2016, Zack Weinberg wrote:
> When experimenting with Joseph's build-many-glibcs.py I found that
> sysdeps/ia64/fpu/libm-symbols.h and the -D switches added to the command
> line by sysdeps/ia64/fpu/Makefile can break the math tests. This patch
> moves the -D switches into libm-symbols.h and makes that file only apply
> when IS_IN(libc)||IS_IN(libm), which is sufficient to clear the test
> failure I observed.
My patch for this is at
<https://sourceware.org/ml/libc-alpha/2016-11/msg00313.html>. I'm not
concerned with which fix goes in as long as this does get fixed.
My other fixes for build-many-glibcs.py are
<https://sourceware.org/ml/libc-alpha/2016-11/msg00314.html> (ia64) and
<https://sourceware.org/ml/libc-alpha/2016-11/msg00584.html> (nios2).
With GCC 6 branch (which seems to give the cleanest results in my
testing), I still get elf/check-execstack and elf/check-textrel failures
for hppa, and elf/check-execstack failing for ia64, which I hope
architecture maintainers might look at (if elf/check-execstack is hard to
fix for an architecture, XFAILing as I did for MIPS with an appropriate
explanatory comment seems reasonable). (There are also build failures for
ColdFire and MicroBlaze because of compiler issues.)
(I hope to extend build-many-glibcs.py for use as a bot to watch for
regressions. If the check stage fails because of existing test failures,
that can hide other tests starting to fail. So clean compilation tests
for all architectures are desirable.)
--
Joseph S. Myers
joseph@codesourcery.com