This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 2/2] New internal function __access_noerrno
On 10/11/2016 16:31, Adhemerval Zanella wrote:
>
>
> On 10/11/2016 15:53, Siddhesh Poyarekar wrote:
>> On Thursday 10 November 2016 10:34 PM, Adhemerval Zanella wrote:
>>> This ia follow up patch for tunables requirement [1]. It Implement
>>> an internal version of __access called __access_noerrno that
>>> avoids setting errno. This is useful to check accessibility of files
>>> very early on in process startup i.e. before TLS setup. This allows
>>> tunables to replace MALLOC_CHECK_ safely (i.e. check existence of
>>> /etc/suid-debug to enable/disable MALLOC_CHECK) and at the same time
>>> initialize very early so that it can override IFUNCs.
>>
>> I think someone else should also review and ack this one, but I'll do a
>> review round anyway.
>
> Thanks, I fixes all my mistakes locally. It would be good to have a
> ack for nacl/hurd before pushing it.
I tried both hurd [1] and nacl [2] environments to check the build but
without success. Hurd VM does not boot with a recent qemu (2.7.50) and
NaCL toolchain seems stuck in a ancient gcc version (4.4.7). Since I
this patch won't break any functionality (since it only adds a new
symbol), I see it should be safe to push.
[1] https://people.debian.org/~sthibault/hurd-i386/README
[2] https://developer.chrome.com/native-client/sdk/download