Re: [PATCH 0/8] More float128 declarations

[Joseph Myers <joseph at codesourcery dot com>]

On Wed, 9 Nov 2016, Joseph Myers wrote:

> This seems inconsistent about whether the recently added TS 18661-1 
> functions are covered or not.  I'd expect all of the following to have 
> version map entries: __iseqsigf128 totalorderf128 totalordermagf128 
> getpayloadf128 canonicalizef128, and, where the definitions aren't 
> type-generic, to have function definitions for float128.

Also, this inconsistency suggests to me that the patches haven't been 
testing in conjunction with subsequent patches that actually enable the 
new functions and their associated tests, because the tests would have 
failed to link if some functions were absent.

Anything that involves adding new files / declarations / macros for each 
new function should probably best have its final review as part of the 
patch series that actually enables the new functions and associated tests 
for at least one system, as otherwise it's hard to have confidence in the 
completeness and correctness of the changes.  (That is, while it's 
possible to spot some issues without such testing, final approval of such 
patches should wait until the code for the new types has gone through 
testing.  Whereas e.g. a conversion of math-finite.h to use macros to 
declare functions could be done in a way involving no float128 
conditionals at all, so entirely suitable to review by itself, with the 
float128 patches then just adapting the macro definitions to handle 
float128.)

-- 
Joseph S. Myers
joseph@codesourcery.com