This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix warning from latest GCC in tst-printf.c


On Tue, 1 Nov 2016, Steve Ellcey wrote:

> On Tue, 2016-11-01 at 17:37 +0000, Joseph Myers wrote:
> > On Tue, 1 Nov 2016, Steve Ellcey wrote:
> > 
> > > 
> > > Ping.  One of the snprintf statements in this test is using a %.999999u
> > > format so it is obvious that the test wants to test formats that would
> > > go beyond the limit of the snprintf buffer and so we should ignore the
> > > warnings in this test.
> > OK provided you've tested that this change works with older GCC that lack 
> > the new option (otherwise it would need to be conditional on the GCC 
> > version).
> 
> I did forget to check it with an older GCC and it does fail with GCC
> 5.4.  Here is a new version with a conditional.   Tested with GCC 5.4
> and GCC 7.0 (prerelease).
> 
> Ok to checkin?

OK.

-- 
Joseph S. Myers
joseph@codesourcery.com

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]