This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v4] Fix -Os related build and test failures.
From: Carlos O'Donell <carlos@redhat.com>
Date: Mon, 31 Oct 2016 05:16:29 -0400
> On 10/31/2016 04:33 AM, Andreas Schwab wrote:
>> https://build.opensuse.org/project/monitor/home:Andreas_Schwab:glibc
>>
>> In file included from strxfrm_l.c:48:0:
>> ../locale/weight.h: In function ʽfindidxʼ:
>> ../locale/weight.h:69:4: error: ʽDIAG_PUSH_NEEDS_COMMENTʼ undeclared (first use in this function)
>> DIAG_PUSH_NEEDS_COMMENT;
>> ^~~~~~~~~~~~~~~~~~~~~~~
>> ../locale/weight.h:69:4: note: each undeclared identifier is reported only once for each function it appears in
>> ../locale/weight.h:70:4: error: implicit declaration of function ʽDIAG_IGNORE_Os_NEEDS_COMMENTʼ [-Werror=implicit-function-declaration]
>> DIAG_IGNORE_Os_NEEDS_COMMENT (5, "-Wmaybe-uninitialized");
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> ../locale/weight.h:74:4: error: ʽDIAG_POP_NEEDS_COMMENTʼ undeclared (first use in this function)
>> DIAG_POP_NEEDS_COMMENT;
>> ^~~~~~~~~~~~~~~~~~~~~~
>
> I'm fixing this. I don't know why this didn't fail on my x86_64 build.
>
> I'm moving the #include <libc-internal.h> into the weight header fragments.
The thread debugging header nptl_db/thread_dbP.h needs it too.