This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Generate additional secret keys for the heap protector

From: Carlos O'Donell <carlos at redhat dot com>
To: Florian Weimer <fweimer at redhat dot com>, libc-alpha at sourceware dot org
Date: Fri, 28 Oct 2016 12:48:31 -0400
Subject: Re: [PATCH] Generate additional secret keys for the heap protector
Authentication-results: sourceware.org; auth=none
References: <20161028130509.A74DC439942E0@oldenburg.str.redhat.com> <b86a9fdf-65c5-fc19-3e9c-63d3545a34f1@redhat.com> <bd0185d8-1172-f9b8-eef1-1d01a71be23f@redhat.com>

On 10/28/2016 11:39 AM, Florian Weimer wrote:
> On 10/28/2016 04:46 PM, Carlos O'Donell wrote:
>> Florian,
>>
>> Awesome patch. This is looking really good and the expansion of entropy
>> into the keys using sha256 looks great.
>>
>> OK to checkin if you:
>>
>> * Fix spelling.
>> * Remove _dl_setup_pointer_guard linux+generic implementation as unused.
>> * Remove _dl_setup_stack_chk_guard linux+generic implementation as unused
> 
> New version attached. I'm waiting until the libcrypt fix is checked
> in (I'll try to test on SPARC and commit if successful). And it only
> makes sense to have this change if we end up with the heap protector,
> so I'll wait for that, too.

This version looks good to me.

-- 
Cheers,
Carlos.

References:
- [PATCH] Generate additional secret keys for the heap protector
  - From: Florian Weimer
- Re: [PATCH] Generate additional secret keys for the heap protector
  - From: Carlos O'Donell
- Re: [PATCH] Generate additional secret keys for the heap protector
  - From: Florian Weimer

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]