This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix warning caused by unused-result in bug-atexit3-lib.cc

On 10/28/2016 03:32 PM, Gabriel F. T. Gomes wrote:

On Fri, 28 Oct 2016 15:04:13 +0200
Florian Weimer <fweimer@redhat.com> wrote:


On 10/28/2016 03:00 PM, Gabriel F. T. Gomes wrote:

The test case dlfcn/bug-atexit3-lib.cc calls write and doesn't check the
result.  When building with GCC 6.2 from IBM's branch, this generates a
warning in 'make check', which is treated as an error.  This patch adds a
return variable to get rid of the warning and of the error.


You could use write_message from test-skeleton.c instead.  it has a
proper unused variable guard.


Is it ok to use write_message in c++ code being built as object?


Oh, right, this probably will not work.  Bummer.
You could copy the function into the .cc file, though. The unused attribute may be needed in the long term. 

Florian
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]