This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] powerpc: Fix TOC stub on powerpc64 clone()


LGTM, it follows what GCC generated for non retur  functions. I am
assuming you actually tested on powerpc64.

On 21/10/2016 19:06, Tulio Magno Quites Machado Filho wrote:
> Use a function call to _exit() so that the linker can create a TOC stub
> instead of just a branch.
> 
> 2016-10-21  Tulio Magno Quites Machado Filho  <tuliom@linux.vnet.ibm.com>
> 
> 	[BZ #20728]
> 	* sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S: Replace a
> 	branch to _exit() by a function call.
> ---
>  sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S b/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S
> index 7c59b9b..df824f5 100644
> --- a/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S
> +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S
> @@ -97,7 +97,7 @@ L(oldpid):
>  #ifdef SHARED
>  	b	JUMPTARGET(__GI__exit)
>  #else
> -	b	JUMPTARGET(_exit)
> +	bl	JUMPTARGET(_exit)
>  	/* We won't ever get here but provide a nop so that the linker
>  	   will insert a toc adjusting stub if necessary.  */
>  	nop
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]