Re: [RFC][PATCH v2 00/11][BZ 10871] Month names in genitive case

[Rical Jasan <ricaljasan at pacific dot net>]

Hi Rafal,

I can't comment on much of the mechanical changes, but it would be nice
if the new feature was documented.

On 10/17/2016 04:54 PM, Rafal Luzynski wrote:

> 1. Add the alternative month names support to nl_langinfo(3) (the
> ALTMON_... constants.)  There are no major differences between the
> previous [6] version and this one except that it has been rebased.

I think the ALTMON_* constants should be added to the list of constants
in the description of nl_langinfo in manual/locale.texi.

> 5. Implement the %OB specifier.  Actually the same as [9], the only
> difference is the Subject line which says it's PATCH 05/11 rather
> than PATCH 3/6.

I think OB should be added to the list of conversion specifiers in the
description of strftime in manual/time.texi.

nl_langinfo is annotated as being part of XOPEN, and strftime is marked
as ISO, so if OB and the associated ALTMON_* constants aren't parts of
those standards, they should have an "@comment GNU" line placed above
the "@item" lines.  It should say so in their descriptions as well;
e.g., "This is a GNU extension."

Your introductions to patches 01/11 and 05/11 are good, so modifying
them to sound right in the context of the manual should be fine.

Thanks,
Rical