This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH COMMITTED] resolv: Compile without -Wno-write-strings
- From: Zack Weinberg <zackw at panix dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 11 Oct 2016 12:52:11 -0400
- Subject: Re: [PATCH COMMITTED] resolv: Compile without -Wno-write-strings
- Authentication-results: sourceware.org; auth=none
- References: <20161011135022.1A7EE439942EF@oldenburg.str.redhat.com>
On Tue, Oct 11, 2016 at 9:50 AM, Florian Weimer <fweimer@redhat.com> wrote:
> extern const struct res_sym __p_class_syms[];
> libresolv_hidden_proto (__p_class_syms)
> const struct res_sym __p_class_syms[] = {
> - {C_IN, "IN"},
> - {C_CHAOS, "CHAOS"},
> - {C_HS, "HS"},
> - {C_HS, "HESIOD"},
> - {C_ANY, "ANY"},
> - {C_NONE, "NONE"},
> - {C_IN, (char *)0}
> + {C_IN, (char *) "IN"},
> + {C_CHAOS, (char *) "CHAOS"},
> + {C_HS, (char *) "HS"},
> + {C_HS, (char *) "HESIOD"},
> + {C_ANY, (char *) "ANY"},
> + {C_NONE, (char *) "NONE"},
> + {C_IN, NULL, NULL}
As these (appear to be) internal symbols, why can't we make `struct
res_sym` const-correct instead of adding all these casts?
zw