This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 1/4] consolidate sign checks for slow2

From: Carlos O'Donell <carlos at redhat dot com>
To: Siddhesh Poyarekar <siddhesh at sourceware dot org>, libc-alpha at sourceware dot org
Date: Tue, 27 Sep 2016 16:03:18 -0400
Subject: Re: [PATCH 1/4] consolidate sign checks for slow2
Authentication-results: sourceware.org; auth=none
References: <1474998553-2366-1-git-send-email-siddhesh@sourceware.org> <1474998553-2366-2-git-send-email-siddhesh@sourceware.org>

On 09/27/2016 01:49 PM, Siddhesh Poyarekar wrote:
> Simplify the code a bit by consolidating sign checks in slow1 and
> slow2 into __sin at the higher level.
> 
> Siddhesh
> 
> 	* sysdeps/ieee754/dbl-64/s_sin.c (slow1): Consolidate sign
> 	check from here...
> 	(slow2): ... and here...
> 	(__sin): ... to here.

LGTM.

-- 
Cheers,
Carlos.

References:
- [PATCH 0/4] Use __copysign in sincos wherever possible
  - From: Siddhesh Poyarekar
- [PATCH 1/4] consolidate sign checks for slow2
  - From: Siddhesh Poyarekar

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]