This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 01/13] Installed-header hygiene (BZ#20366): obsolete BSD u_* types.
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Zack Weinberg <zackw at panix dot com>, libc-alpha at sourceware dot org
- Cc: joseph at codesourcery dot com
- Date: Wed, 21 Sep 2016 13:41:51 -0400
- Subject: Re: [PATCH 01/13] Installed-header hygiene (BZ#20366): obsolete BSD u_* types.
- Authentication-results: sourceware.org; auth=none
- References: <20160830011645.25769-1-zackw@panix.com> <20160830011645.25769-2-zackw@panix.com>
On 08/29/2016 09:16 PM, Zack Weinberg wrote:
> * bits/in.h, gmon/sys/gmon.h, inet/netinet/igmp.h
> * inet/protocols/routed.h, inet/protocols/talkd.h
> * inet/protocols/timed.h, io/fts.h, nptl_db/thread_db.h
> * resolv/arpa/nameser.h, resolv/resolv.h, sunrpc/rpc/rpc_des.h
> * sysdeps/generic/netinet/if_ether.h
> * sysdeps/generic/netinet/in_systm.h
> * sysdeps/generic/netinet/ip.h, sysdeps/generic/netinet/tcp.h
> * sysdeps/gnu/netinet/ip_icmp.h, sysdeps/gnu/netinet/tcp.h
> * sysdeps/gnu/netinet/udp.h, sysdeps/mach/hurd/net/ethernet.h
> * sysdeps/mach/hurd/net/if_arp.h
> * sysdeps/mach/hurd/net/if_ppp.h
> * sysdeps/mach/hurd/net/route.h, sysdeps/mach/sys/reboot.h
> * sysdeps/unix/sysv/linux/bits/in.h
> * sysdeps/unix/sysv/linux/net/ethernet.h
> * sysdeps/unix/sysv/linux/net/if_arp.h
> * sysdeps/unix/sysv/linux/net/if_ppp.h
> * sysdeps/unix/sysv/linux/net/if_shaper.h
> * sysdeps/unix/sysv/linux/net/route.h
> * sysdeps/unix/sysv/linux/netinet/if_ether.h
> * sysdeps/unix/sysv/linux/netinet/if_fddi.h
> * sysdeps/unix/sysv/linux/netinet/if_tr.h
> * sysdeps/unix/sysv/linux/netipx/ipx.h
> * sysdeps/unix/sysv/linux/sys/acct.h
> * sysdeps/unix/sysv/linux/sys/quota.h
> * include/arpa/nameser.h, include/resolv.h:
> Change all uses of u_char to unsigned char,
> u_short and ushort to unsigned short, u_int and uint to unsigned int,
> u_long and ulong to unsigned long, u_int8_t to uint8_t,
> u_int16_t to uint16_t, u_int32_t to uint32_t, quad_t to int64_t,
> and u_int64_t and u_quad_t to uint64_t.
Patch looks good conditional on fixing the over a dozen places where
the changes have caused overly long lines.
--
Cheers,
Carlos.