Re: [PATCH] Add missing RR type numbers to ns_type

[Florian Weimer <fweimer at redhat dot com>]

On 08/17/2016 02:57 PM, Nathaniel McCallum wrote:
> On Wed, 2016-08-17 at 10:52 +0200, Florian Weimer wrote:
> > On 08/16/2016 10:52 PM, Nathaniel McCallum wrote:
> > > From a53a3428ee7c2c1dc3e3ff7e682e87f6694d9a55 Mon Sep 17 00:00:00
> > > 2001
> > > From: Nathaniel McCallum <npmccallum@redhat.com>
> > > Date: Tue, 16 Aug 2016 16:43:29 -0400
> > > Subject: [PATCH] Add missing RR type numbers to ns_type
> > >
> > > The ns_type enumeration was missing quite a few resource records.
> > > This
> > > patch updates the enumeration to reflect the current state of the
> > > IANA
> > > DNS Parameters registry.
> > >
> > >     http://www.iana.org/assignments/dns-parameters/dns-parameters.x
> > > html
> >
> > The problem with <arpa/nameser.h> is that it is stuck in the
> > past.  It
> > was never updated for DNSSECbis (which is incompatible with the
> > original
> > DNSSEC).  And there are declarations in it which do not have
> > implementations in glibc.
> >
> > I was leaning towards deprecating the header and eventually removing
> > it.
> >   What kind of use do you see for it?
>
> I'm fine with that. So long as you are on the record, I can use this
> conversation to discourage the use of this header in projects that
> object to RR types that aren't in the enum.

I pondered this some more and suggest to remove just the DNSSEC cruft 
from <arpa/nameser.h> and then synchronize with the IANA registry.  The 
header file seems sufficiently widely used so that maintaining it makes 
sense.

I have posted a few patches to clean it up.  Once these patches are in, 
could you rebase your patch on top of it?  I think you also should 
update <arpa/nameser_compat.h> (whose name is a bit of a misnomer, it is 
always included by <arpa/nameser.h>).

Thanks,
Florian