This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2] Add getrandom implementation [BZ #17252]


On 09/08/2016 12:12 PM, Andreas Schwab wrote:

+      if (!((flags & GRND_RANDOM)
+            && (flags & GRND_NONBLOCK)

Please add != 0 (no implicit boolean coercion).

The wiki says this is okay (search for “foo & BIT”):

  <https://sourceware.org/glibc/wiki/Style_and_Conventions>

Thanks,
Florian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]