This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 12/18] arm64: ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it
- From: Arnd Bergmann <arnd at arndb dot de>
- To: libc-alpha at sourceware dot org
- Cc: Bamvor Jian Zhang <bamvor dot zhangjian at huawei dot com>, Yury Norov <ynorov at caviumnetworks dot com>, catalin dot marinas at arm dot com, linux-arm-kernel at lists dot infradead dot org, linux-kernel at vger dot kernel dot org, linux-doc at vger dot kernel dot org, linux-arch at vger dot kernel dot org, schwidefsky at de dot ibm dot com, heiko dot carstens at de dot ibm dot com, pinskia at gmail dot com, broonie at kernel dot org, joseph at codesourcery dot com, christoph dot muellner at theobroma-systems dot com, szabolcs dot nagy at arm dot com, klimov dot linux at gmail dot com, Nathan_Lynch at mentor dot com, agraf at suse dot de, Prasun dot Kapoor at caviumnetworks dot com, kilobyte at angband dot pl, geert at linux-m68k dot org, philipp dot tomsich at theobroma-systems dot com, manuel dot montezelo at gmail dot com, linyongting at huawei dot com, maxim dot kuvyrkov at linaro dot org, davem at davemloft dot net, zhouchengming1 at huawei dot com, cmetcalf at ezchip dot com, Andrew Pinski <apinski at cavium dot com>, Andrew Pinski <Andrew dot Pinski at caviumnetworks dot com>, Hanjun Guo <guohanjun at huawei dot com>, chenjianguo 00365834 <chenjianguo3 at huawei dot com>, jijun 00321192 <jijun2 at huawei dot com>
- Date: Fri, 02 Sep 2016 14:55:34 +0200
- Subject: Re: [PATCH 12/18] arm64: ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it
- Authentication-results: sourceware.org; auth=none
- References: <1471434403-25291-1-git-send-email-ynorov@caviumnetworks.com> <1471434403-25291-13-git-send-email-ynorov@caviumnetworks.com> <57C9587B.9080006@huawei.com>
On Friday, September 2, 2016 6:46:19 PM CEST Bamvor Jian Zhang wrote:
> diff --git a/arch/arm64/include/uapi/asm/unistd.h b/arch/arm64/include/uapi/asm/unistd.h
> index 043d17a..78bea1d 100644
> --- a/arch/arm64/include/uapi/asm/unistd.h
> +++ b/arch/arm64/include/uapi/asm/unistd.h
> @@ -16,4 +16,9 @@
>
> #define __ARCH_WANT_RENAMEAT
>
> +/* We need to make sure it works for both userspace and kernel(sys_ilp32.c) */
> +#if defined(__ILP32__) || defined(__SYSCALL_COMPAT)
> +#define __ARCH_WANT_SYNC_FILE_RANGE2
> +#endif
> +
> #include <asm-generic/unistd.h>
> diff --git a/arch/arm64/kernel/sys_ilp32.c b/arch/arm64/kernel/sys_ilp32.c
> index 10fc0ca..13c9c9d 100644
> --- a/arch/arm64/kernel/sys_ilp32.c
> +++ b/arch/arm64/kernel/sys_ilp32.c
> @@ -42,7 +42,7 @@
> #define compat_sys_pwrite64 compat_sys_pwrite64_wrapper
> #define compat_sys_readahead compat_sys_readahead_wrapper
> #define compat_sys_shmat sys_shmat
> -#define compat_sys_sync_file_range compat_sys_sync_file_range2_wrapper
> +#define compat_sys_sync_file_range2 compat_sys_sync_file_range2_wrapper
> #define compat_sys_truncate64 compat_sys_truncate64_wrapper
> #define sys_mmap2 compat_sys_mmap2_wrapper
> #define sys_ptrace compat_sys_ptrace
>
Looks good to me.
Arnd