This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv2 2/5] ldbl-128: Define and use mathx_hidden_def wrapper to hidden_def
On Thu, 18 Aug 2016, Paul E. Murphy wrote:
> +/* We need to guarantee an expansion of name when building
> + ldbl-128 files as another type (e.g _Float128). */
> +#define mathx_hidden_def(name) hidden_def(name)
Space before '(' in call to hidden_def, and "e.g" should be "e.g.". But
really I'd rather see this patch in the context of a later patch series
where it's actually used; it may well be the right approach, but that
isn't entirely clear for the patch in isolation / in the present series.
--
Joseph S. Myers
joseph@codesourcery.com