This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv2 03/11] Support for type-generic libm function implementations libm
On Fri, 5 Aug 2016, Paul E. Murphy wrote:
> +# Functions built through generic templates declared in gen-libm-calls
> +generated += $(foreach s,.c .S,$(call type-foreach,$(gen-libm-calls:%=%$(s))))
I don't see why you need to handle .S here (and so why you need the outer
foreach at all). These templates should only generate .c files.
> +/* Use a special epsilon value for IBM long double
> + to avoid spurious overflows. */
It's either overflows or underflows (or maybe both) depending on the
function being built; the comment should reflect this rather than just
saying overflows.
OK with those fixes unless anyone identifies any other issues within 48
hours.
--
Joseph S. Myers
joseph@codesourcery.com