This is the mail archive of the mailing list for the glibc project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] x86: Use sysdep.o from libc.a in static libraries

Fedora needs to relink libpthread.a into a single object file to support some application needs. Starting with

commit fb1cf108115f7e2e4510859693431b3473657d77
Author: H.J. Lu <>
Date:   Tue Oct 13 11:58:53 2015 -0700


this prevents static linking due to multiple copies of the functions from sysdep.o.

The attached patch skips adding sysdep.o for static libraries. Okay to commit?

(No bug filed because this is a downstream bug only, but dropping the additional copy of sysdep.o seems to make sense upstream as well.)

x86: Use sysdep.o from libc.a in static libraries

Static libraries can use the sysdep.o copy in libc.a without
a performance penalty.  This results in a visible difference
if libpthread.a is relinked into a single object file (which
is needed to support libraries which check for the presence
of certain symbols to enable threading support, which generally
fails with static linking unless libpthread.a is relinked).

2016-08-04  Florian Weimer  <>

	Use sysdep.o from libc.a in static libraries.
	* sysdeps/unix/sysv/linux/i386/Makefile
	(libpthread-shared-only-routines): Add sysdep.
	(librt-shared-only-routines): Likewise.

diff --git a/sysdeps/unix/sysv/linux/i386/Makefile b/sysdeps/unix/sysv/linux/i386/Makefile
index 71ba61e..b015ff7 100644
--- a/sysdeps/unix/sysv/linux/i386/Makefile
+++ b/sysdeps/unix/sysv/linux/i386/Makefile
@@ -48,9 +48,11 @@ endif
 ifeq ($(subdir),nptl)
 # pull in __syscall_error routine
 libpthread-routines += sysdep
+libpthread-shared-only-routines += sysdep
 ifeq ($(subdir),rt)
 # pull in __syscall_error routine
 librt-routines += sysdep
+librt-shared-only-routines += sysdep

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]