This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH x86_64][BZ #20033] Use calls to finite scalar versions in vector log, pow, exp.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: Andrew Senkevich <andrew dot n dot senkevich at gmail dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Mon, 25 Jul 2016 20:19:49 +0000
- Subject: Re: [PATCH x86_64][BZ #20033] Use calls to finite scalar versions in vector log, pow, exp.
- Authentication-results: sourceware.org; auth=none
- References: <CAMXFM3sd6tPCyqxhKHERWtKswc5AYqyvc_mYjt7=miAuK5jJ0Q@mail.gmail.com> <alpine.DEB.2.20.1607201638070.12251@digraph.polyomino.org.uk> <CAMXFM3tMZp58=LeYT+Dd6hCCjrPm4eK-GUMxQkM4yCjT2-3dkg@mail.gmail.com>
On Mon, 25 Jul 2016, Andrew Senkevich wrote:
> > No, such architecture conditionals on individual tests are not
> > appropriate. Maybe you need a NO_TEST_VECTOR handled like NO_TEST_INLINE
> > in enable_test.
>
> Is patch below Ok for trunk?
No, I said handled like NO_TEST_INLINE. Exactly like NO_TEST_INLINE. No
architecture conditionals, no #if, just an "if" conditional exactly
corresponding to how NO_TEST_INLINE and NON_FINITE are handled (the
NON_FINITE if is actually better to follow since it follows the glibc
convention of avoiding implicit boolean conversion).
--
Joseph S. Myers
joseph@codesourcery.com