This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] all: #define __WORDSIZE32_SIZE_ULONG and __WORDSIZE32_PTRDIFF_LONG everywhere
- From: Yury Norov <ynorov at caviumnetworks dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: <libc-alpha at sourceware dot org>, <joseph at codesourcery dot com>, <arnd at arndb dot de>, <catalin dot marinas at arm dot com>, <davem at davemloft dot net>, <szabolcs dot nagy at arm dot com>, <maxim dot kuvyrkov at linaro dot org>, <pinskia at gmail dot com>, <bamvor dot zhangjian at huawei dot com>, <fweimer at redhat dot com>, <Prasun dot Kapoor at cavium dot com>, <adhemerval dot zanella at linaro dot org>, Andrew Pinski <apinski at cavium dot com>
- Date: Thu, 7 Jul 2016 02:25:40 +0300
- Subject: Re: [PATCH] all: #define __WORDSIZE32_SIZE_ULONG and __WORDSIZE32_PTRDIFF_LONG everywhere
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp.mailfrom=Yuri dot Norov at caviumnetworks dot com;
- References: <1467843094-2914-1-git-send-email-ynorov@caviumnetworks.com> <87a8hu1ios.fsf@linux-m68k.org>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
On Thu, Jul 07, 2016 at 12:54:27AM +0200, Andreas Schwab wrote:
> Yury Norov <ynorov@caviumnetworks.com> writes:
>
> > diff --git a/sysdeps/aarch64/bits/wordsize.h b/sysdeps/aarch64/bits/wordsize.h
> > new file mode 100644
> > index 0000000..8bcbea9
> > --- /dev/null
> > +++ b/sysdeps/aarch64/bits/wordsize.h
> > @@ -0,0 +1,29 @@
> > +/* Determine the wordsize from the preprocessor defines.
> > +
> > + Copyright (C) 2016 Free Software Foundation, Inc.
> > + This file is part of the GNU C Library.
> > +
> > + The GNU C Library is free software; you can redistribute it and/or
> > + modify it under the terms of the GNU Lesser General Public
> > + License as published by the Free Software Foundation; either
> > + version 2.1 of the License, or (at your option) any later version.
> > +
> > + The GNU C Library is distributed in the hope that it will be useful,
> > + but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> > + Lesser General Public License for more details.
> > +
> > + You should have received a copy of the GNU Lesser General Public
> > + License along with the GNU C Library; if not, see
> > + <http://www.gnu.org/licenses/>. */
> > +
> > +#ifdef __LP64__
> > +# define __WORDSIZE 64
> > +# define __WORDSIZE32_SIZE_ULONG 0
> > +# define __WORDSIZE32_PTRDIFF_LONG 0
> > +#else
> > +# define __WORDSIZE 32
> > +# define __WORDSIZE32_SIZE_ULONG 1
> > +# define __WORDSIZE32_PTRDIFF_LONG 1
> > +#endif
>
> There should be a comment explaining their meaning.
__WORDSIZE and __WORDSIZE32_SIZE_ULONG are not new macros, so no
description is needed, right?
I don't know much about __WORDSIZE32_PTRDIFF_LONG. Andrew told it's for
some testcases in gcc testsuite.
> > +
>
> Trailing empty line (in all files).
>
> Andreas.
Oh, I did it right opposite. Will fix later.
Yury.