This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 0/6] Generate Complex functions from a common template.
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Fri, 1 Jul 2016 16:14:07 +0000
- Subject: Re: [PATCH 0/6] Generate Complex functions from a common template.
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1467323999 dot git dot murphyp at linux dot vnet dot ibm dot com> <alpine dot DEB dot 2 dot 20 dot 1606302231240 dot 21713 at digraph dot polyomino dot org dot uk> <47407f77-d129-cb9e-6cbe-1230a52355ea at linux dot vnet dot ibm dot com>
On Thu, 30 Jun 2016, Paul E. Murphy wrote:
> > In such cases, the right thing to do is to have preliminary patches that
> > only address the drift, so that the comparison is clean in the subsequent
> > stages.
>
> I believe there are only 4 such cases, and are very limited.
> Spurious usage of glibc_likely in two cases, and two cases
> of testing for FE_INVALID macro before trying to raise it.
>
> The behavior is exclusive to s_ccosh*.c and s_csinh*.c.
>
> The diff isn't much obfuscated by either. If you can
> tell me which is the desired behavior, I can propose
> and submit those patches independently.
Remove the #ifdef FE_INVALID. Architectures not defining FE_* exceptions
also have math_private.h defining feraiseexcept to do nothing.
Do not use __glibc_likely on rcls == FP_INFINITE.
--
Joseph S. Myers
joseph@codesourcery.com