This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH V2] powerpc: Add a POWER8-optimized version of expf()
- From: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- To: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
- Cc: munroesj at linux dot vnet dot ibm dot com
- Cc:
- Date: Thu, 30 Jun 2016 16:20:03 -0300
- Subject: Re: [PATCH V2] powerpc: Add a POWER8-optimized version of expf()
- Authentication-results: sourceware.org; auth=none
- References: <277c499f-08dc-bad5-c364-377dd28ef8cc at linux dot vnet dot ibm dot com> <1467054190-1634-1-git-send-email-tuliom at linux dot vnet dot ibm dot com> <fddcaa2f-00d8-41a5-8949-ecb7f16d649f at linux dot vnet dot ibm dot com>
"Paul E. Murphy" <murphyp@linux.vnet.ibm.com> writes:
> This appears like it would fail to export the __ieee754_expf symbol
> when linking statically. Could it be handled similarly to s_isnanf.c?
>
> Otherwise, the patch is OK to me.
Yes. Fixed locally.
> I think the tiny increase in ULPS is acceptable given the speedup this
> version brings. Tulio, it is probably worth noting a rough estimate in
> the commit message.
I made the changes locally and will push it.
Thanks!
--
Tulio Magno