This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] powerpc: Add a POWER8-optimized version of expf()
- From: "Tulio Magno Quites Machado Filho" <tuliom at linux dot vnet dot ibm dot com>
- To: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>, libc-alpha at sourceware dot org
- Cc: munroesj at linux dot vnet dot ibm dot com
- Cc:
- Date: Mon, 27 Jun 2016 10:33:07 -0300
- Subject: Re: [PATCH] powerpc: Add a POWER8-optimized version of expf()
- Authentication-results: sourceware.org; auth=none
- References: <1466715228-29670-1-git-send-email-tuliom at linux dot vnet dot ibm dot com> <f4acab4b-b7b2-21d0-4676-f3320089c715 at linux dot vnet dot ibm dot com>
"Paul E. Murphy" <murphyp@linux.vnet.ibm.com> writes:
> On 06/23/2016 03:53 PM, Tulio Magno Quites Machado Filho wrote:
>> +#ifndef __ieee754_expf
>> +# define IS_MAIN_DEF
>> +#endif
>
>> +#ifdef IS_MAIN_DEF
>> +strong_alias (__ieee754_expf, __expf_finite)
>> +#endif
>>
>
> This is inconsistent with many of the other ppc64
> multiarch files.
>
> Why not undef and redefine strong_alias in
> e_expf-power8.S?
It's intentional.
Because undef doesn't make it clear when the macro is defined or not.
So, you reach a code that may do nothing depending on how this file
was included.
> Similarly, the formatting seems inconsistent with
> the other PPC asm.
Could you give me more details, please?
--
Tulio Magno