This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 20/27] [AARCH64] Make lp64 and ilp32 directories.
- From: Arnd Bergmann <arnd at arndb dot de>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: Yury Norov <ynorov at caviumnetworks dot com>, libc-alpha at sourceware dot org, linux-kernel at vger dot kernel dot org, catalin dot marinas at arm dot com, marcus dot shawcroft at arm dot com, philb at gnu dot org, davem at davemloft dot net, szabolcs dot nagy at arm dot com, maxim dot kuvyrkov at linaro dot org, joseph at codesourcery dot com, pinskia at gmail dot com, Andrew Pinski <apinski at cavium dot com>
- Date: Mon, 27 Jun 2016 10:03:04 +0200
- Subject: Re: [PATCH 20/27] [AARCH64] Make lp64 and ilp32 directories.
- Authentication-results: sourceware.org; auth=none
- References: <1466485631-3532-1-git-send-email-ynorov at caviumnetworks dot com> <1466485631-3532-22-git-send-email-ynorov at caviumnetworks dot com> <mvmlh1rkqua dot fsf at hawking dot suse dot de>
On Monday, June 27, 2016 9:56:13 AM CEST Andreas Schwab wrote:
> Yury Norov <ynorov@caviumnetworks.com> writes:
>
> > diff --git a/sysdeps/unix/sysv/linux/aarch64/bits/fcntl.h b/sysdeps/unix/sysv/linux/aarch64/bits/fcntl.h
> > index 658f696..7dcbe65 100644
> > --- a/sysdeps/unix/sysv/linux/aarch64/bits/fcntl.h
> > +++ b/sysdeps/unix/sysv/linux/aarch64/bits/fcntl.h
> > @@ -25,7 +25,11 @@
> > #define __O_NOFOLLOW 0100000
> > #define __O_DIRECT 0200000
> >
> > -#define __O_LARGEFILE 0
> > +#ifdef __ILP32__
> > +# define __O_LARGEFILE 0400000
> > +#else
> > +# define __O_LARGEFILE 0
> > +#endif
>
> Is there any point in defining O_LARGEFILE to non-zero if the kernel is
> enforcing it anyway?
The kernel might want to return -EINVAL for undefined flags. I'm not
sure if we want to do that here, but it would seem like a correct
return code.
Arnd