This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] test-skeleton.c: Do not enable M_PERTURB
- From: Siddhesh Poyarekar <siddhesh at sourceware dot org>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 23 Jun 2016 20:19:33 +0530
- Subject: Re: [PATCH] test-skeleton.c: Do not enable M_PERTURB
- Authentication-results: sourceware.org; auth=none
- References: <20160623144042 dot E649F41C390E5 at oldenburg dot str dot redhat dot com>
On Thu, Jun 23, 2016 at 04:40:42PM +0200, Florian Weimer wrote:
> Over all, this decreases the realism of the tests because
> it ensures that freshly allocated memory has a well-defined
> bit pattern. It also causes malloc to take internal paths
> different from regular application usage, and therefore
> reduces malloc test coverage.
The well-defined bit pattern is more likely to catch any bad tests
though, which might make it valuable. However, I agree that it makes
sense to remove it for malloc tests.