This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix p{readv,writev}{64} consolidation implementation
- From: Florian Weimer <fweimer at redhat dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Wed, 22 Jun 2016 11:57:27 +0200
- Subject: Re: [PATCH] Fix p{readv,writev}{64} consolidation implementation
- Authentication-results: sourceware.org; auth=none
- References: <1465941275-3459-1-git-send-email-adhemerval dot zanella at linaro dot org> <20160615053714 dot GM4053 at vapier dot lan> <177f35c1-5934-00c7-a24b-901947505fee at redhat dot com> <20160615154119 dot GS4053 at vapier dot lan>
On 06/15/2016 05:41 PM, Mike Frysinger wrote:
>> I think we should really have some sort of libtest.a, which provides
>> test helpers, error-checking functions such as xmalloc, and general
>> helpers for setting up special test environments. I'm a bit worried
>> about figuring out the proper dependencies, so that libtest.a is built
>> before all the tests are linked.
>
> isn't this what test-skeleton.c does for us now ? and we all agree that
> all tests should be using that.
There are limits to what we can put into test-skeleton.c due to symbol
conflicts and dependencies of the test harness which are incompatible
with some things which we want to test.
With libtest.a, we can still have clean compilation environments for
tests, and the linker will sort out things for us. (We can even have
ELF constructors which get pulled into the link as needed.)
> imo we should just mandate all tests use the entry point "do_test" and it
> take argc/argv args (even if they're unused), and then all tests can pull
> test-skeleton.c in at the top.
Yes, seems a reasonable improvement, and mostly unrelated.
Thanks,
Florian