This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 11/27] [AARCH64] Syscalls for ILP32 are passed always via 64bit values.
- From: Andreas Schwab <schwab at suse dot de>
- To: "Zhangjian \(Bamvor\)" <bamvor dot zhangjian at huawei dot com>
- Cc: Yury Norov <ynorov at caviumnetworks dot com>, <libc-alpha at sourceware dot org>, <linux-kernel at vger dot kernel dot org>, <arnd at arndb dot de>, <catalin dot marinas at arm dot com>, <marcus dot shawcroft at arm dot com>, <philb at gnu dot org>, <davem at davemloft dot net>, <szabolcs dot nagy at arm dot com>, <maxim dot kuvyrkov at linaro dot org>, <joseph at codesourcery dot com>, <pinskia at gmail dot com>, Andrew Pinski <apinski at cavium dot com>, <gaoyongliang at huawei dot com>
- Date: Tue, 21 Jun 2016 13:54:36 +0200
- Subject: Re: [PATCH 11/27] [AARCH64] Syscalls for ILP32 are passed always via 64bit values.
- Authentication-results: sourceware.org; auth=none
- References: <1466485631-3532-1-git-send-email-ynorov at caviumnetworks dot com> <1466485631-3532-13-git-send-email-ynorov at caviumnetworks dot com> <mvmlh1zrn55 dot fsf at hawking dot suse dot de> <5769281D dot 6090109 at huawei dot com>
"Zhangjian (Bamvor)" <bamvor.zhangjian@huawei.com> writes:
> Hi,
>
> On 2016/6/21 15:56, Andreas Schwab wrote:
>> Yury Norov <ynorov@caviumnetworks.com> writes:
>>
>>> diff --git a/sysdeps/unix/sysv/linux/aarch64/sysdep.h b/sysdeps/unix/sysv/linux/aarch64/sysdep.h
>>> index 1ffabc2..42f89c8 100644
>>> --- a/sysdeps/unix/sysv/linux/aarch64/sysdep.h
>>> +++ b/sysdeps/unix/sysv/linux/aarch64/sysdep.h
>>> @@ -161,11 +161,11 @@
>>> call. */
>>> # undef INLINE_SYSCALL
>>> # define INLINE_SYSCALL(name, nr, args...) \
>>> - ({ unsigned long _sys_result = INTERNAL_SYSCALL (name, , nr, args); \
>>> + ({ unsigned long long _sys_result = INTERNAL_SYSCALL (name, , nr, args); \
>>> if (__builtin_expect (INTERNAL_SYSCALL_ERROR_P (_sys_result, ), 0))\
>>> { \
>>> __set_errno (INTERNAL_SYSCALL_ERRNO (_sys_result, )); \
>>> - _sys_result = (unsigned long) -1; \
>>> + _sys_result = (unsigned long long) -1; \
>>> } \
>>> (long) _sys_result; })
>>
>> The cast should be (long long).
> My understanding that we need more conversion, reference the follow patch:
And this:
diff --git a/sysdeps/unix/sysv/linux/aarch64/sysdep.c b/sysdeps/unix/sysv/linux/aarch64/sysdep.c
index f2d5480..1bec443 100644
--- a/sysdeps/unix/sysv/linux/aarch64/sysdep.c
+++ b/sysdeps/unix/sysv/linux/aarch64/sysdep.c
@@ -19,13 +19,13 @@
#include <sysdep.h>
#include <errno.h>
-long __syscall_error (long err);
+long long __syscall_error (long long err);
hidden_proto (__syscall_error)
/* This routine is jumped to by all the syscall handlers, to stash
an error number into errno. */
-long
-__syscall_error (long err)
+long long
+__syscall_error (long long err)
{
__set_errno (- err);
return -1;
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."