This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 04/27] [AARCH64] Add PTR_REG, PTR_LOG_SIZE, and PTR_SIZE. Use it in LDST_PCREL and LDST_GLOBAL.
- From: Andreas Schwab <schwab at suse dot de>
- To: Yury Norov <ynorov at caviumnetworks dot com>
- Cc: <libc-alpha at sourceware dot org>, <linux-kernel at vger dot kernel dot org>, <arnd at arndb dot de>, <catalin dot marinas at arm dot com>, <marcus dot shawcroft at arm dot com>, <philb at gnu dot org>, <davem at davemloft dot net>, <szabolcs dot nagy at arm dot com>, <maxim dot kuvyrkov at linaro dot org>, <joseph at codesourcery dot com>, <pinskia at gmail dot com>, Andrew Pinski <apinski at cavium dot com>
- Date: Tue, 21 Jun 2016 11:13:09 +0200
- Subject: Re: [PATCH 04/27] [AARCH64] Add PTR_REG, PTR_LOG_SIZE, and PTR_SIZE. Use it in LDST_PCREL and LDST_GLOBAL.
- Authentication-results: sourceware.org; auth=none
- References: <1466485631-3532-1-git-send-email-ynorov at caviumnetworks dot com> <1466485631-3532-6-git-send-email-ynorov at caviumnetworks dot com> <mvmporbrn7c dot fsf at hawking dot suse dot de>
Andreas Schwab <schwab@suse.de> writes:
>> +/* Load or store to/from a got-relative EXPR into/from R, using T.
>> + Note R and T are register numbers and not register names. */
>> +#define LDST_GLOBAL(OP, R, T, EXPR) \
>> + adrp x##T, :got:EXPR; \
>> + ldr PTR_REG (T), [x##T, #:got_lo12:EXPR]; \
>> + OP x##R, [x##T];
>
> I think this needs to be PTR_REG(x).
I mean PTR_REG(R), of course.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."