This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2] Fix misaligned access accessing HEADER struct in res_query.c

From: John David Anglin <dave dot anglin at bell dot net>
To: John David Anglin <dave dot anglin at bell dot net>
Cc: GNU C Library <libc-alpha at sourceware dot org>, Carlos O'Donell <carlos at redhat dot com>, Mike Frysinger <vapier at gentoo dot org>
Date: Fri, 17 Jun 2016 18:52:26 -0400
Subject: Re: [PATCH v2] Fix misaligned access accessing HEADER struct in res_query.c
Authentication-results: sourceware.org; auth=none
References: <5E7CF115-219A-4260-BE53-19B5A8D1D7F3 at bell dot net>

The attached patch fixes BZ 20243. It uses the gcc aligned attribute to decrease the
alignment of variables using the HEADER type.  This results in byte accesses being
used for the structure fields and thereby avoids the misaligned accesses noted in the BZ.

The change no longer affects the public interface for the HEADER type.

Tested with trunk and Debian 2.22 builds on hppa-linux.  No regressions were observed in the
test results.

Please install if okay.

Dave
--
John David Anglin	dave.anglin@bell.net

Attachment: submitted-header.diff.txt
Description: Text document

Follow-Ups:
- Re: [PATCH v2] Fix misaligned access accessing HEADER struct in res_query.c
  - From: Mike Frysinger

References:
- [PATCH] Fix misaligned access accessing HEADER struct in res_query.c
  - From: John David Anglin

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]