This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 16 Jun 2016 14:56, Andreas Schwab wrote: > Zack Weinberg writes: > > On Thu, Jun 16, 2016 at 12:48 AM, Mike Frysinger wrote: > >> + fclose (stderr); > >> + dup2 (STDOUT_FILENO, STDERR_FILENO); > >> + stderr = fdopen (STDERR_FILENO, "w"); > > > > Wouldn't the dup2 be sufficient by itself? And then you don't have to > > worry about allocation failure in fdopen. > > > > Also a setbuf(stderr, NULL) is probably appropriate. > > Also, assigning stderr is a nono. portability-wise, you are correct. it works under glibc though. the only other way to change one of these is to use freopen() and that requires a FS path, and that's less portable to construct, and less reliable to use (since FS perms are checked at open() time but not at dup() time). -mike
Attachment:
signature.asc
Description: Digital signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |