This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Refactor part of math Makefile
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Date: Tue, 14 Jun 2016 21:04:11 +0000
- Subject: Re: [PATCH] Refactor part of math Makefile
- Authentication-results: sourceware.org; auth=none
- References: <8d257095-c2da-0b8c-1740-00c8552d4ec8 at linux dot vnet dot ibm dot com>
On Tue, 14 Jun 2016, Paul E. Murphy wrote:
> + gamma_productF k_standardF lgamma_negF lgamma_productF \
> +
> +libm-compat-calls = w_lgamma_compatf w_lgamma_compat w_lgamma_compatl
Given the conclusion that we should obsolete matherr / _LIB_VERSION as
part of the preparation for adding a new type, k_standard should end up in
the set of compat calls as well. (The new cleaner wrappers used for new
types, and for static linking / new ports for existing types, would handle
errno setting directly without calling __kernel_standard.)
> +libm-tests = $(foreach t,$(types),test-$(t) \
> + test-$(t)-finite \
> + test-i$(subst ldouble,ldoubl,$(t))) \
I don't think we should keep the irregularity of the test being called
test-ildoubl rather than ildouble. Rename it and you no longer need a
special $(subst ldouble,ldoubl,$(t)).
--
Joseph S. Myers
joseph@codesourcery.com