This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
RE: [PATCH] Fix the atomic_compare_and_exchange_*_rel definitions.
- From: Lei Xu <lei dot xu at nxp dot com>
- To: Tulio Magno Quites Machado Filho <tuliom at linux dot vnet dot ibm dot com>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>
- Cc: Scott Wood <scott dot wood at nxp dot com>, "carlos at systemhalted dot org" <carlos at systemhalted dot org>, "sjmunroe at us dot ibm dot com" <sjmunroe at us dot ibm dot com>
- Date: Tue, 14 Jun 2016 05:58:32 +0000
- Subject: RE: [PATCH] Fix the atomic_compare_and_exchange_*_rel definitions.
- Authentication-results: sourceware.org; auth=none
- Authentication-results: spf=none (sender IP is ) smtp dot mailfrom=lei dot xu at nxp dot com;
- References: <1465723849-12811-1-git-send-email-lei dot xu at nxp dot com> <87h9cx894b dot fsf at totoro dot br dot ibm dot com>
- Spamdiagnosticmetadata: NSPM
- Spamdiagnosticoutput: 1:99
Hello, Tulio
Thank you and please see my comments below~
-----Original Message-----
From: Tulio Magno Quites Machado Filho [mailto:tuliom@linux.vnet.ibm.com]
Sent: Monday, June 13, 2016 10:19 PM
To: Lei Xu; libc-alpha@sourceware.org
Cc: Scott Wood; carlos@systemhalted.org; sjmunroe@us.ibm.com
Subject: Re: [PATCH] Fix the atomic_compare_and_exchange_*_rel definitions.
Hi Lei,
Lei Xu <lei.xu@nxp.com> writes:
> In current code, atomic_compare_and_exchange_*_rel is defined as
> atomic_compare_and_exchange_*_acq, however this is wrong on power
> arch, especially __arch_*_rel has been defined on power arch.
> This has caused segmentation fault issue when doing
> pthread_mutex_lock/unlock operations on PowerPC E6500.
I didn't expect the generic code to affect a PowerPC E6500 build.
It should be using both of the files:
sysdeps/powerpc/atomic-machine.h
sysdeps/powerpc/powerpc32/atomic-machine.h
These files define atomic_compare_and_exchange_val_rel(), which should prevent from defining the atomic_compare_and_exchange_val_rel() as
atomic_compare_and_exchange_val_acq() in the generic file.
[XuLei] It defines atomic_compare_and_exchange_val_rel in sysdeps/powerpc/bits/atomic.h, but not define atomic_compare_and_exchange_bool_rel.
I will paste another solution in next email and would like to get your comments, thanks.
So, there is a chance your build didn't use these files...
How are you configuring your glibc build?
--
Tulio Magno