This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] nptl: Add sendmmsg and recvmmsg cancellation tests
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Mon, 13 Jun 2016 10:48:09 -0400
- Subject: Re: [PATCH v2] nptl: Add sendmmsg and recvmmsg cancellation tests
- Authentication-results: sourceware.org; auth=none
- References: <1465590903-10194-1-git-send-email-adhemerval dot zanella at linaro dot org>
On 06/10/2016 04:35 PM, Adhemerval Zanella wrote:
> Changes from previous version:
>
> - Added separated tests for both sendmmsg and recvmmsg.
>
> --
>
> This patch adds cancellation tests for both sendmmsg and recvmmsg
> syscalls. Since for some system configuration (x86_64/i686 on
> older kernels and non-Linux platforms), the tests are added as
> two independent that report as unsupported if the syscall is not
> presented.
>
> Both new tests uses the already tst-cancel4.c code, which as moved
> to a common tst-cancel4-common{.c,h} files.
>
> Tested on x86_64 and i686.
>
> * nptl/Makefile (test): Add tst-cancel4_1 and tst-cancel4_2.
> * nptl/tst-cancel4-common.c: New file.
> * nptl/tst-cancel4-common.h: Likewise.
> * nptl/tst-cancel4.c: Move common definitions to
> tst-cancel4-common.{c,h} file.
> * nptl/tst-cancel4_1.c: New test.
> * nptl/tst-cancel4_2.c: New test.
This looks good to me.
OK to commit if you tested the UNSUPPORTED case by either hacking
out the syscall wrapper to return ENOSYS or running on a system
that didn't have sendmmsg.
I think hakcing sysdeps/unix/sysv/linux/sendmmsg.c to return ENOSYS,
recompile, recheck, should be enough to test UNSUPPORTED was wired
up properly.
Cheers,
Carlos.