Re: [RFC v2][PATCH 22/27] Export stack_used as __stack_used

[Gary Benson <gbenson at redhat dot com>]

Pedro Alves wrote:
> On 06/13/2016 11:38 AM, Gary Benson wrote:
> > The Infinity note libpthread::thr_iter (broadly equivalent to
> > libthread_db's td_ta_thr_iter) requires access to both
> > __stack_user and stack_used, but only the former is visible to it.
> > This commit renames "stack_used" as "__stack_used" and changes it
> > from a static variable in allocatestack.c to an internally
> > exported symbol available to all nptl source files.
> 
> This rename alone should fix glibc PR 17629 (and thus GDB PR 9635).
> 
>  [put all symbols nptl_db looks up in the private namespace]
>  https://sourceware.org/bugzilla/show_bug.cgi?id=17629
> 
> Thus I think it'd be reasonable (and good) to split the renaming
> part of this patch out of the series, and get it into the tree.  I
> think it could go in quickly.

I wasn't aware of that bug.  I'll leave it a day or so to see if
anyone has any comments, then I'll mail just this change alone.

> BTW, the td_ta_thr_iter.c::iterate_thread_list hunk looks like just
> a code style change unrelated to the subject of the patch.

It's not a style change, it stops it falling through into the rest
of the function if next == 0 and !fake_empty.

I agree it should be a separate patch though.

Cheers,
Gary

-- 
http://gbenson.net/