Re: [PATCH v4] When using the Mozilla NSS library for cryptography, include the NSPR header files

[Mike Frysinger <vapier at gentoo dot org>]

On 11 Jun 2016 09:12, Florian Weimer wrote:
> On 06/11/2016 08:04 AM, Mike Frysinger wrote:
> > On 31 May 2016 21:25, Guido Trentalancia wrote:
> >> When configuring and building GNU libc using the Mozilla NSS library
> >> for cryptography (--enable-nss-crypt option), also include the
> >> NSPR header files along with the Mozilla NSS library header files.
> >>
> >> Finally, when running the check-local-headers test, ignore the
> >> Mozilla NSPR library header files (used by the Mozilla NSS library)
> >> as otherwise false positives (FAIL) are obtained.
> >
> > imo, we should switch to pkg-config, and then probe nss via that.
> > then we don't have to know or care about nspr requirements.
> 
> Isn't using pkg-config in a GNU project a bit tricky?

i don't see why it would be.  it's pretty much defacto now for any
reasonable library.  GNOME, a GNU project, is heavily invested in
it.

> In any case, Mozilla does not publish pkg-config data as far as I can 
> see, and downstreams probably vary in what they do.  For example, Fedora 
> does not provide pkg-config data for libfreebl at all.

sorry, i thought the pc file was from upstream.  then again, i'll note
that the nss-config script isn't upstream either, so we're in the same
situation: we're left with whatever distros have done.

>  You can link 
> against NSS, but then you also get libdl and libpthread, which we do not 
> want as dependencies of libgcrypt.

i'm not sure what you're saying here.  `pkg-config --libs nss` doesn't
pull in any of those libs.  and here we only care about what compiler
settings are exposed by `pkg-config --cflags nss`.
-mike

Attachment: signature.asc
Description: Digital signature