This is the mail archive of the
mailing list for the glibc project.
Re: [PATCH] X86-64: Add dummy memcopy.h and wordcopy.c
- From: Roland McGrath <roland at hack dot frob dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 10 Jun 2016 14:59:22 -0700 (PDT)
- Subject: Re: [PATCH] X86-64: Add dummy memcopy.h and wordcopy.c
- Authentication-results: sourceware.org; auth=none
- References: <20160608210059 dot GA6694 at intel dot com>
There's no reason for the header, since sysdeps/generic/memcopy.h is just a
header. In an x86_64 build, nothing should #include it and so that's fine.
The files outside string/ that #include <memcopy.h> do so for no reason at
all and those lines should just be removed from all of them.
wordcopy.c is probably unused on several architectures. One approach would
be to just drop it from routines in string/Makefile and add it via
sysdep_routines for machines that actually need it. That doesn't seem
quite right because generic string/foo.c uses it, but every architecture
having a dummy file seems icky.