This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [BZ #19654] Added tests for *_finite aliases from libmvec


2016-05-18 2:06 GMT+03:00 Joseph Myers <joseph@codesourcery.com>:
> On Sat, 20 Feb 2016, Andrew Senkevich wrote:
>
>> +  if (log_res[0] != 0.0) abort ();
>> +  if (exp_res[0] != 1.0) abort ();
>> +  if (pow_res[0] != 1.0) abort ();
>
> Aborting is not the right way for a test to report an error.  Rather, the
> function should return an error status to its caller (ending up with
> do_test returning 1 on error, 0 on success - and ideally 77 for
> UNSUPPORTED tests, which would be those where CHECK_ARCH_EXT fails).

Please find attached new version.
Here also AVX512 versions are untested if GCC version is less than 6.1
(because earlier 2 calls of AVX2 version generated).


--
WBR,
Andrew

Attachment: bz19654_new.patch
Description: Binary data


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]