This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] [BZ 17956] Fix build failure due to missing definitions from header file nss/nss.h when Mozilla NSS is used for cryptography
- From: Carlos O'Donell <carlos at redhat dot com>
- To: Guido Trentalancia <guido at trentalancia dot net>, Adhemerval Zanella <adhemerval dot zanella at linaro dot org>, libc-alpha at sourceware dot org
- Date: Tue, 31 May 2016 11:50:59 -0400
- Subject: Re: [PATCH v2] [BZ 17956] Fix build failure due to missing definitions from header file nss/nss.h when Mozilla NSS is used for cryptography
- Authentication-results: sourceware.org; auth=none
- References: <1464635653 dot 24965 dot 5 dot camel at trentalancia dot net> <1464700854 dot 24965 dot 21 dot camel at trentalancia dot net> <574DA91E dot 9040508 at linaro dot org> <1464708782 dot 2379 dot 12 dot camel at trentalancia dot net>
On 05/31/2016 11:33 AM, Guido Trentalancia wrote:
> Please let me know if the ChangeLog is required for the first two
> patches and I will be glad to prepare one (what has been changed is
> trivial and explained in the header of each patch).
Adhemerval or myself can write the ChangeLog for you as a first time
contributor.
The real issue is that I don't think your patch are quite correct
or we haven't found the real cause of the failure.
On Fedora we use --enable-nss-crypt for all of our builds and see
no problems.
You add nss3/nspr include directories to CFLAGS, which should not
be needed.
Your configure fails if you don't, and *that* is the key problem
we should be looking at.
The NSS headers are derived from calling, as they should:
nss-config --includedir
And that is used everywhere it is needed.
So the fault appears to be in your nss-config?
What does your failing config.log show?
What does `nss-config --includedir` print on your system?
--
Cheers,
Carlos.