This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 3/3] posix: New Linux posix_spawn{p} implementation
- From: Adhemerval Zanella <adhemerval dot zanella at linaro dot org>
- To: Florian Weimer <fweimer at redhat dot com>, Eric Wong <e at 80x24 dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 30 May 2016 10:03:26 -0300
- Subject: Re: [PATCH 3/3] posix: New Linux posix_spawn{p} implementation
- Authentication-results: sourceware.org; auth=none
- References: <1456770820-21341-1-git-send-email-adhemerval dot zanella at linaro dot org> <1456770820-21341-4-git-send-email-adhemerval dot zanella at linaro dot org> <20160529095429 dot GA9311 at starla> <88ab5d2a-05c0-d5a5-f543-901d438fe328 at redhat dot com>
On 30/05/2016 08:02, Florian Weimer wrote:
> On 05/29/2016 11:54 AM, Eric Wong wrote:
>> Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
>>> +static int
>>> +__spawni_child (void *arguments)
>>
>> <snip>
>>
>>> +fail:
>>> + /* Since sizeof errno < PIPE_BUF, the write is atomic. */
>>> + ret = -ret;
>>> + if (ret)
>>> + while (write_not_cancel (p, &ret, sizeof ret) < 0)
>>> + continue;
>>> + exit (SPAWN_ERROR);
>>> +}
>>
>> Sorry for not noticing earlier, but shouldn't it be
>> "_exit" instead of "exit" when the child fails?
>
> Good point. Would you file a bug for this, please?
>
> Thanks,
> Florian
Thanks for reporting, I opened BZ#20178.
[1] https://sourceware.org/bugzilla/show_bug.cgi?id=20178