This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCHv2 11/14] Apply LIT(x) to floating point literals in libm-test.c
- From: Joseph Myers <joseph at codesourcery dot com>
- To: "Paul E. Murphy" <murphyp at linux dot vnet dot ibm dot com>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 24 May 2016 15:43:05 +0000
- Subject: Re: [PATCHv2 11/14] Apply LIT(x) to floating point literals in libm-test.c
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1463779745 dot git dot murphyp at linux dot vnet dot ibm dot com> <d544a21f4e723511ac026930826fae446f7647d4 dot 1463779745 dot git dot murphyp at linux dot vnet dot ibm dot com>
On Fri, 20 May 2016, Paul E. Murphy wrote:
> if ($descr[$i] =~ /f|i|l|L/) {
> - $cline .= ", $args[$current_arg]";
> + if ($descr[$i] eq "f" and not ($args[0] eq "nexttoward" and $current_arg == 2)) {
Rather than specially checking for the name "nexttoward" here, I think it
would be cleaner to use something other than "f" as the argument
descriptor for the case where the argument is always long double, and
rename struct test_ff_f_data_nexttoward accordingly. (Strictly you don't
need to create another macro like RUN_TEST_LOOP_ff_f with the
corresponding name and use it for the nexttoward tests, but it's probably
cleaner to do so as well.)
(Nothing should actually be using the first argument to TEST_* any more;
it's a relic from when TEST_* generated code rather than data, which
hasn't been cleaned up yet.)
--
Joseph S. Myers
joseph@codesourcery.com